Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment #1898

Merged
merged 2 commits into from
Sep 6, 2021
Merged

[201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment #1898

merged 2 commits into from
Sep 6, 2021

Conversation

bingwang-ms
Copy link
Contributor

@bingwang-ms bingwang-ms commented Sep 3, 2021 •
edited
Loading

What I did
This PR is a cherry-pick of #1761 from master branch to 201811 branch.
I have to create another PR to pick up the code since it's not a cleanup cherry-pick. Some UT code issues wrere fixed as well.
This PR will fix #1891

Why I did it
Please see #1761

How I verified it
Verifyed by UT

pytest test_mirror.py -v                                   
===================================================================================================================== test session starts ======================================================================================================================
platform linux2 -- Python 2.7.15+, pytest-3.3.0, py-1.10.0, pluggy-0.6.0 -- /usr/bin/python2.7
cachedir: .cache
rootdir: /home/bingwang/workspace/sonic-swss/tests, inifile:
collected 6 items                                                                                                                                                                                                                                              

test_mirror.py::TestMirror::test_MirrorAddRemove PASSED                                                                                                                                                                                                  [ 16%]
test_mirror.py::TestMirror::test_MirrorToVlanAddRemove PASSED                                                                                                                                                                                            [ 33%]
test_mirror.py::TestMirror::test_MirrorToLagAddRemove PASSED                                                                                                                                                                                             [ 50%]
test_mirror.py::TestMirror::test_MirrorDestMoveVlan PASSED                                                                                                                                                                                               [ 66%]
test_mirror.py::TestMirror::test_MirrorDestMoveLag PASSED                                                                                                                                                                                                [ 83%]
test_mirror.py::TestMirror::test_AclBindMirror PASSED                                                                                                                                                                                                    [100%]

================================================================================================================== 6 passed in 158.96 seconds ==================================================================================================================

Details if related

@bingwang-ms bingwang-ms requested review from qiluo-msft, lguohan and prsunny and removed request for qiluo-msft September 3, 2021 15:44
@bingwang-ms bingwang-ms force-pushed the cherry_pick_1761_2018 branch from cf8f9f1 to 52591a6 Compare September 6, 2021 00:50
@bingwang-ms
Fix test issue
71dd816 
Signed-off-by: bingwang <[email protected]>
@bingwang-ms bingwang-ms merged commit 3503705 into sonic-net:201811 Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@lguohan lguohan Awaiting requested review from lguohan

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bingwang-ms @prsunny